Add text support to the Trainer's TensorBoard integration#34418
Merged
SunMarc merged 8 commits intohuggingface:mainfrom Nov 4, 2024
Merged
Add text support to the Trainer's TensorBoard integration#34418SunMarc merged 8 commits intohuggingface:mainfrom
SunMarc merged 8 commits intohuggingface:mainfrom
Conversation
JacobLinCool
changed the title
Member
|
Feel free to merge when good @SunMarc |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
SunMarc
approved these changes
Nov 4, 2024
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Awesome ! Thanks for integrating my suggestion.
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…e#34418) * feat: add text support to TensorBoardCallback * feat: ignore long strings in trainer progress * docs: add docstring for max_str_len * style: remove trailing whitespace --------- Co-authored-by: Marc Sun <57196510+SunMarc@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add text support to
TensorBoardCallbackso users can see the decoded text generated incompute_metricsin TensorBoard. Sometimes the string is very long, so amax_str_len(defaults to 100) property has also been added toProgressCallbackto prevent polluting the progress log.Can be used to checkout transcription when fine-tuning ASR models:
Before submitting
Pull Request section?
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.