Skip to content

fix incorrect warning #34416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yonigozlan merged 3 commits into from
Oct 29, 2024
+7 −6
Merged

fix incorrect warning #34416

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
de9f91c
fix incorrect warning
yonigozlan Oct 25, 2024
05a8018
Merge branch 'main' into fix-incorrect-warning
yonigozlan Oct 29, 2024
7828800
Merge branch 'main' into fix-incorrect-warning
yonigozlan Oct 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/transformers/processing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -874,12 +874,13 @@ class MyProcessingKwargs(ProcessingKwargs, CommonKwargs, TextKwargs, ImagesKwarg
else:
# kwargs is a flat dictionary
for key in kwargs:
if key not in ModelProcessorKwargs.__annotations__["common_kwargs"].__annotations__.keys():
logger.warning_once(
f"Keyword argument `{key}` is not a valid argument for this processor and will be ignored."
)
elif key not in used_keys:
output_kwargs["common_kwargs"][key] = kwargs[key]
if key not in used_keys:
if key in ModelProcessorKwargs.__annotations__["common_kwargs"].__annotations__.keys():
output_kwargs["common_kwargs"][key] = kwargs[key]
else:
logger.warning_once(
f"Keyword argument `{key}` is not a valid argument for this processor and will be ignored."
)

# all modality-specific kwargs are updated with common kwargs
for modality in output_kwargs:
Expand Down