Merged
Conversation
BenjaminBossan
approved these changes
Oct 25, 2024
Member
BenjaminBossan
left a comment
There was a problem hiding this comment.
I don't have enough background to judge if the fix is good, but the test should cover it, as the generate call itself would raise an error without the fix.
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
approved these changes
Oct 28, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks, noting as it will be in a patch
Comment on lines
+946
to
+947
| # We shouldn't hit the default value unless for quant methods like hqq that modifies expected_keys. | ||
| old_param = getattr(old_param, split, None) |
Collaborator
There was a problem hiding this comment.
😅 I knew it!
It was a bit too specific
ArthurZucker
pushed a commit
that referenced
this pull request
Oct 29, 2024
* fix regression * add test for torchao * expected output * better fix
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* fix regression * add test for torchao * expected output * better fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the regression that @BenjaminBossan found out. It was caused by this PR. Basically,
old_paramwas always going to beNonewith the current logic. Hence, we don't set the correct dtype to the parameterparam = param.to(old_param.dtype). This caused a dtype mismatch with torchao.To reproduce
I tested that hqq serialization and the new test that I added both passed