Fix perplexity computation in perplexity.md#34387
Merged
ArthurZucker merged 3 commits intohuggingface:mainfrom Oct 29, 2024
Merged
Fix perplexity computation in perplexity.md#34387ArthurZucker merged 3 commits intohuggingface:mainfrom
ArthurZucker merged 3 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
fix average NLL in perplexity.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This pull request fixes an issue in the code of the Perplexity of fixed-length models documentation. The current implementation computes the arithmetic mean of the negative log-likelihood (NLL) per sequence chunk without accounting for the varying number of tokens in each chunk. This can lead to an inaccurate average NLL per token, as tokens in smaller chunks (like the last one) have a higher weight in the final perplexity calculation. The PR computes the arithmetic mean of NLL per token. The perplexity error is small in the provided example (
16.4541vs.16.4443), but I guess that it can be larger for shorter sequences.Before submitting
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@stevhliu @ArthurZucker