Un-deprecate timeout arg in pipelines#34382
Conversation
|
cc @LysandreJik @Wauplin for review! |
Rocketknight1
changed the title
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
left a comment
Wauplin
left a comment
There was a problem hiding this comment.
Thanks @Rocketknight1! Looks good. Let's wait for another review though
|
|
||
|
|
||
| def compare_pipeline_args_to_hub_spec(pipeline_class, hub_spec): | ||
| ALLOWED_TRANSFORMERS_ONLY_ARGS = ["timeout"] |
There was a problem hiding this comment.
Maybe over-engineering things here but I would make this list pipeline-specific
There was a problem hiding this comment.
(feel free to ignore though, we can also do it next time a "transformers"-only arg is added)
There was a problem hiding this comment.
Yeah, it shouldn't be too painful to make that change when we need to!
|
(x-linking #34290 (comment) where this PR was discussed) |
Rocketknight1
force-pushed
the
un_deprecate_timeout
branch
from
b685a2d to
9cc9c6a
Compare
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Yes! Thanks @Rocketknight1
Rocketknight1
force-pushed
the
un_deprecate_timeout
branch
from
9cc9c6a to
81d367c
Compare
* Un-deprecate timeout * Put "timeout" on the allowed list * make fixup
4 participants
As part of the pipeline sync project, this PR allows some arguments in
transformersthat don't have to be in the Hub spec. This is limited to arguments that do not actually affect the core pipeline, liketimeout, which controls the timeout for downloading images passed as path arguments.