Skip to content

Fix performance in get_imports regexp #34298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rocketknight1 merged 2 commits into from
Oct 29, 2024
Merged

Fix performance in get_imports regexp #34298

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7eb529
fix: Fix performance in get_imports regexp
AlekseyLobanov Oct 21, 2024
b0c4e3d
Minimize get_imports content regexp
AlekseyLobanov Oct 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformers/dynamic_module_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,8 @@ def get_imports(filename: Union[str, os.PathLike]) -> List[str]:
content = f.read()

# filter out try/except block so in custom code we can have try/except imports
content = re.sub(r"\s*try\s*:\s*.*?\s*except\s*.*?:", "", content, flags=re.MULTILINE | re.DOTALL)
content = re.sub(r"\s*try\s*:.*?except.*?:", "", content, flags=re.DOTALL)

# filter out imports under is_flash_attn_2_available block for avoid import issues in cpu only environment
content = re.sub(
r"if is_flash_attn[a-zA-Z0-9_]+available\(\):\s*(from flash_attn\s*.*\s*)+", "", content, flags=re.MULTILINE
Expand Down