Bug Fix for issue #34294#34295
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 31, 2024
Merged
Conversation
Update SiglipVisionEmbeddings.forward to cast input to correct dtype before embedding it.
qubvel
approved these changes
Oct 30, 2024
Contributor
There was a problem hiding this comment.
Thanks for the update!
Comment for core maintainers
Update SigLIP similar to CLIP:
transformers/src/transformers/models/clip/modeling_clip.py
Lines 247 to 248 in 32590b5
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Update SiglipVisionEmbeddings.forward to cast input to correct dtype before embedding it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update SiglipVisionEmbeddings.forward to cast input to correct dtype before embedding it.
Fixes #34294
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@amyeroberts @qubvel