Ignore unsupported kwarg in ProcessorMixin call#34285
Merged
yonigozlan merged 1 commit intohuggingface:mainfrom Oct 24, 2024
Merged
Ignore unsupported kwarg in ProcessorMixin call#34285yonigozlan merged 1 commit intohuggingface:mainfrom
yonigozlan merged 1 commit intohuggingface:mainfrom
Conversation
molbap
approved these changes
Oct 22, 2024
Contributor
molbap
left a comment
There was a problem hiding this comment.
Just curious, did you try with text/audio processors with overlapping names? No conflict in the handling logic? other than that LGTM! thanks for the fix :)
Member
Author
|
@molbap Just tested with |
ArthurZucker
approved these changes
Oct 24, 2024
Merged
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Fix accept any common kwargs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
When a processor kwarg that is not supported by any modality is passed to a ProcessorMixin call, it is added to CommonKwargs whether or not it is supported by the ProcessorMixin's CommonKwargs object.
This means that any kwargs passed to a processor call will that is not supported by any modality will still be added to all modality kwargs, which can lead to errors. Example:
gives
And a
TypeErrorAfter this fix:
Who can review?
@molbap