manual head_dim for mixtral model#34281
Merged
ArthurZucker merged 1 commit intohuggingface:mainfrom Oct 29, 2024
Merged
Conversation
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Hey! Sounds good, could you make sure to fix the cis and rebase? 🤗
0ba1484 to
cc09202
Compare
Contributor
Author
|
@ArthurZucker I literally have no idea why the CI check fails at glm modeling code. I did not make any changes to the glm models. Can you help me with this or can you give me a brief guideline? |
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
These were fixed on main! You can now rebase and should be good!
Collaborator
|
|
cc09202 to
486a932
Compare
Contributor
Author
|
@ArthurZucker I did |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
head_dimsetting formixtralmodelllamaandmistralimplementationFixes #34261
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ArthurZucker @gante