Merged
Conversation
Contributor
Author
|
Hi @SunMarc! This PR is ready for review, please, take a look. |
SunMarc
approved these changes
Oct 17, 2024
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks for your work ! Left a question
VladOS95-cyber
force-pushed
the
add-gguf-for-mamba
branch
2 times, most recently
from
cb2d641 to
38e402c
Compare
Contributor
Author
|
Hey @SunMarc! Do you have any questions or comments regarding this PR? |
SunMarc
reviewed
Oct 22, 2024
VladOS95-cyber
force-pushed
the
add-gguf-for-mamba
branch
5 times, most recently
from
bd11280 to
775024b
Compare
SunMarc
approved these changes
Oct 25, 2024
Member
SunMarc
left a comment
SunMarc
left a comment
There was a problem hiding this comment.
Thanks for digging into that ! LGTM !
VladOS95-cyber
force-pushed
the
add-gguf-for-mamba
branch
4 times, most recently
from
b8c95b9 to
b2eee3b
Compare
LysandreJik
approved these changes
Oct 28, 2024
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot @VladOS95-cyber
VladOS95-cyber
force-pushed
the
add-gguf-for-mamba
branch
from
b2eee3b to
4cb01c4
Compare
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* add mamba architecture for gguf * add logic for weights conversion, some fixes and refactoring * add lm_head layers, unit test refactoring * more fixes for tests * remove lm_head creation * remove unused comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add GGUF support for Mamba
Before submitting
Pull Request section?
to it if that's the case. Link: Community contribution: Adding GGUF support for more architectures #33260
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Regarding the task @SunMarc @LysandreJik @ArthurZucker.