Merged
Conversation
qubvel
commented
Oct 9, 2024
Comment on lines
214
to
-218
| image_processor_names.append(cls_name) | ||
| elif "FeatureExtractor" in cls_name: | ||
| feature_extractor_names.append(cls_name) | ||
| else: | ||
| raise ValueError(f"Unknown processor class: {cls_name}") |
Contributor
Author
There was a problem hiding this comment.
Pix2Struct model has Processor object in tiny model json, and that led to an error raised for Pix2Struct and filed test. Error raise is not required here because we take the processor from PROCESSOR_MAPPING_NAMES, we can just skip this Processor
Comment on lines
+243
to
249
| at_least_one_model_is_tested = True | ||
|
|
||
| if task in task_to_pipeline_and_spec_mapping: | ||
| pipeline, hub_spec = task_to_pipeline_and_spec_mapping[task] | ||
| compare_pipeline_args_to_hub_spec(pipeline, hub_spec) | ||
|
|
||
| at_least_one_model_is_tested = True | ||
|
|
||
| if not at_least_one_model_is_tested: |
Contributor
Author
There was a problem hiding this comment.
It looks like it was a wrong merge with main, some tests are marked as skipped while they were not actually skipped
LysandreJik
approved these changes
Oct 10, 2024
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Thanks! cc @Rocketknight1 for knowledge (please ping him for anything pipeline-related)
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
* Fix wrong skip annotation * Remove error raise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Following
pipelineable to loadprocessor#32514