Tests: upcast logits to float()
#34042
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
LysandreJik
approved these changes
Oct 10, 2024
Member
LysandreJik
left a comment
LysandreJik
left a comment
There was a problem hiding this comment.
Sounds fair to me! Thanks @gante
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Some of our
forwardnumerical checks comparelogitsagainst expected values. #33902 removes the upcast scheduled for deprecation inforward(logits = logits.float()), resulting in significant memory savings.However, our tests were expecting the cast. This PR is a fix for (some of) those tests. e.g. two slow tests in
llamaare fixed as a result of this PR.(text search ->
EXPECTED_SLICE, used in tests that comparelogitsagainst hardcoded values -> fix whenever applicable )