Handle Trainer tokenizer kwarg deprecation with decorator#33887
Merged
qubvel merged 2 commits intohuggingface:mainfrom Oct 2, 2024
Merged
Handle Trainer tokenizer kwarg deprecation with decorator#33887qubvel merged 2 commits intohuggingface:mainfrom
tokenizer kwarg deprecation with decorator#33887qubvel merged 2 commits intohuggingface:mainfrom
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
amyeroberts
reviewed
Oct 2, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Yes - a lot cleaner - thanks!
amyeroberts
approved these changes
Oct 2, 2024
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…ace#33887) * Handle deprecation with decorator * Fix for seq2seq Trainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Handle Trainer
tokenizerkwarg deprecation with decorator instead of manual deprecationFollow-up PR for
Who can review?
@amyeroberts