Uniformize kwargs for Paligemma processor and update docs#33571
Merged
yonigozlan merged 2 commits intohuggingface:mainfrom Sep 19, 2024
Merged
Uniformize kwargs for Paligemma processor and update docs#33571yonigozlan merged 2 commits intohuggingface:mainfrom
yonigozlan merged 2 commits intohuggingface:mainfrom
Conversation
40 tasks
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
molbap
approved these changes
Sep 19, 2024
Contributor
molbap
left a comment
molbap
left a comment
There was a problem hiding this comment.
Beautiful! Thanks a lot :)
amyeroberts
approved these changes
Sep 19, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for adding!
Main comment is just about the default for tokenize_newline_separately
Comment on lines
39
to
42
Contributor
Contributor
There was a problem hiding this comment.
yes! I'll open a PR to do a batch replace towards
from processing_utils import Unpack
yonigozlan
force-pushed
the
uniformize-processor-paligemma
branch
from
5ccdb6e to
8e6b55b
Compare
|
Hey. Thanks for taking this up and continuing on my PR and completing it. I was caught up with a lot of work and wasn't able to fix issues after the last iteration. |
BernardZach
pushed a commit
to BernardZach/transformers
that referenced
this pull request
Dec 5, 2024
…e#33571) * Uniformize paligemma processor * nit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds uniformized processors kwargs following #31911 for Paligemma.
Continuation of #32377 .
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@molbap @amyeroberts