Skip to content

fix the wandb logging issue #33464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LysandreJik merged 6 commits into from
Sep 18, 2024
Merged

fix the wandb logging issue #33464

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4f05c5d
fix the wandb logging issue
ZIYU-DEEP Sep 13, 2024
e50a57b
Merge branch 'huggingface:main' into fix-wandb-config
ZIYU-DEEP Sep 13, 2024
bbef91a
handle ConfigError in WandbCallback; move import to local scope
ZIYU-DEEP Sep 13, 2024
a78d361
Merge branch 'huggingface:main' into fix-wandb-config
ZIYU-DEEP Sep 18, 2024
d38265b
update integration_utils.py; move import of ConfigError
ZIYU-DEEP Sep 18, 2024
a0099f0
Update integration_utils.py: remove trailing whitespace
ZIYU-DEEP Sep 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/transformers/integrations/integration_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -803,6 +803,10 @@ def setup(self, args, state, model, **kwargs):
if self._wandb is None:
return
self._initialized = True

# prepare to handle potential configuration issues during setup
from wandb.sdk.lib.config_util import ConfigError as WandbConfigError

if state.is_world_process_zero:
logger.info(
'Automatic Weights & Biases logging enabled, to disable set os.environ["WANDB_DISABLED"] = "true"'
Expand Down Expand Up @@ -852,7 +856,13 @@ def setup(self, args, state, model, **kwargs):
try:
self._wandb.config["model/num_parameters"] = model.num_parameters()
except AttributeError:
logger.info("Could not log the number of model parameters in Weights & Biases.")
logger.info(
"Could not log the number of model parameters in Weights & Biases due to an AttributeError."
)
except WandbConfigError:
logger.warning(
"A ConfigError was raised whilst setting the number of model parameters in Weights & Biases config."
)

# log the initial model architecture to an artifact
if self._log_model.is_enabled:
Expand Down