Skip to content

[i18n-ar] Translated file : docs/source/ar/accelerate.md into Arabic#33016

Closed
AhmedAlmaghz wants to merge 7 commits intohuggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_accelerate.md
Closed

[i18n-ar] Translated file : docs/source/ar/accelerate.md into Arabic#33016
AhmedAlmaghz wants to merge 7 commits intohuggingface:mainfrom
AhmedAlmaghz:Add_docs_source_ar_accelerate.md

Conversation

@AhmedAlmaghz
Copy link
Contributor

What does this PR do?

Translated the docs/source/ar/accelerate.md file of the documentation to Arabic العربية. I use transformers for my side-project and wanted to contribute. As a beginner, this seemed appropriate.

Some questions:

  • I can't access the pr documentation endpoint for Arabic العربية. Is there a missing step?
  • I left all the other files alone after copying the English docs. Is this acceptable for future updates or should I add contents to the _toctree.yml only when translation is complete? Should I delete all other files for a cleaner review?
  • In Arabic, people use both Transformer and المحولات to describe the model. However, as this is more of a product of HuggingFace I opted not to translate it. May you please let me know which you would prefer?

Thank you in advance for your review.

Part of #32435

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline, Pull Request section?
  • Was this discussed/approved via a Github issue or the forum ?Please add a link to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the documentation guidelines, and here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@stevhliu , @MKhalusova , @abodacs, may you please review this PR?

@stevhliu
Copy link
Member

stevhliu commented Aug 22, 2024

Hi, when opening PRs, it is generally good not to open a ton at once. This gives reviewers time to review them without being overwhelmed (especially since there is currently only one Arabic reviewer). I recommend opening one or just a few PRs at once (you can even bundle them into one), waiting for them to be reviewed and merged, and then opening the next set of PRs.

@AhmedAlmaghz
Copy link
Contributor Author

Thank you very much for your valuable comments - @stevhliu
I took @abodacs comments and modified the previous pull requests to make the translation better.

Copy link
Contributor

@abodacs abodacs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

السﻻم عليكم
@AhmedAlmaghz
جزيل الشكر
تمت المراجعة

AhmedAlmaghz and others added 6 commits September 4, 2024 07:42
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
Co-authored-by: Abdullah Mohammed <554032+abodacs@users.noreply.github.com>
@AhmedAlmaghz
Copy link
Contributor Author

أشكرك من اعماق قلبي أخي/ عبدالله
الله يبارك فيك
@abodacs

@abodacs
Copy link
Contributor

abodacs commented Sep 4, 2024

@AhmedAlmaghz
جزاك الله خيرا

ممكن تجول الحالة من draft to open

@AhmedAlmaghz AhmedAlmaghz marked this pull request as ready for review September 4, 2024 15:12
@AhmedAlmaghz AhmedAlmaghz deleted the Add_docs_source_ar_accelerate.md branch September 16, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants