Skip to content

fix: Fixed CodeGenTokenizationTest::test_truncation failing test #32850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 3 commits into from
Aug 27, 2024
Merged

fix: Fixed CodeGenTokenizationTest::test_truncation failing test #32850

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c695ca
Fixed failing CodeGenTokenizationTest::test_truncation.
Sai-Suraj-27 Aug 16, 2024
e38e148
[run_slow] Codegen
Sai-Suraj-27 Aug 16, 2024
82b8041
[run_slow] codegen
Sai-Suraj-27 Aug 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions tests/models/codegen/test_tokenization_codegen.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,12 +254,12 @@ def test_truncation(self):
tokenizer = CodeGenTokenizer.from_pretrained("Salesforce/codegen-350M-mono")

text = "\nif len_a > len_b:\n result = a\nelse:\n result = b\n\n\n\n#"
expected_trucated_text = "\nif len_a > len_b: result = a\nelse: result = b"
expected_truncated_text = "\nif len_a > len_b:\n result = a\nelse:\n result = b"

input_ids = tokenizer.encode(text)
truncation_pattern = ["^#", re.escape("<|endoftext|>"), "^'''", '^"""', "\n\n\n"]
decoded_text = tokenizer.decode(input_ids, truncate_before_pattern=truncation_pattern)
self.assertEqual(decoded_text, expected_trucated_text)
self.assertEqual(decoded_text, expected_truncated_text)
Copy link
Collaborator

@ArthurZucker ArthurZucker Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TBH this looks good to me! Given that the truncation pattern does not include \n as an individual character, it's a bug fix!

# TODO @ArthurZ outputs of the fast tokenizer are different in this case, un-related to the PR

# tokenizer has no padding token
Expand Down