Fix typo in classification function selection logic to improve code consistency#32031
Merged
amyeroberts merged 1 commit intohuggingface:mainfrom Jul 17, 2024
flarehealth:issue-32030
Merged
Fix typo in classification function selection logic to improve code consistency#32031amyeroberts merged 1 commit intohuggingface:mainfrom flarehealth:issue-32030
amyeroberts merged 1 commit intohuggingface:mainfrom
flarehealth:issue-32030
Conversation
The latter condition generally overrides the former, so this is more of a code reading issue. I'm not sure the bug would ever actually get triggered under normal use.
Contributor
|
Hi! I think you should be tagging this? #32030 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32030
(previously tagged
#32013)The existing logic has a typo in it, where, for example, it selects a sigmoid classification function if the problem type is "multi_label_classification" or num_labels is 1. The num_labels condition overrides the problem_type condition, so in practice, I don't think this error will cause a bug, but it's confusing.
This fix corrects the problem type conditions.
Please review at your convenience @Narsil