Skip to content

Fix pipeline tests - don't set torch_dtype on non-torch pipelines #31809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
amyeroberts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix pipeline tests - don't set torch_dtype on non-torch pipelines #31809

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/test_pipeline_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ class PipelineTesterMixin:
pipeline_model_mapping = None
supported_frameworks = ["pt", "tf"]

def run_task_tests(self, task, torch_dtype="float32"):
def run_task_tests(self, task, torch_dtype=None):
Copy link
Collaborator

@ydshieh ydshieh Jul 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes the changes (themselves) make more sense. But see my overall comments.

"""Run pipeline tests for a specific `task`

Args:
Expand Down Expand Up @@ -177,7 +177,7 @@ def run_task_tests(self, task, torch_dtype="float32"):
)

def run_model_pipeline_tests(
self, task, repo_name, model_architecture, tokenizer_names, processor_names, commit, torch_dtype="float32"
self, task, repo_name, model_architecture, tokenizer_names, processor_names, commit, torch_dtype=None
):
"""Run pipeline tests for a specific `task` with the give model class and tokenizer/processor class names

Expand Down Expand Up @@ -221,7 +221,7 @@ def run_model_pipeline_tests(
)

def run_pipeline_test(
self, task, repo_name, model_architecture, tokenizer_name, processor_name, commit, torch_dtype="float32"
self, task, repo_name, model_architecture, tokenizer_name, processor_name, commit, torch_dtype=None
):
"""Run pipeline tests for a specific `task` with the give model class and tokenizer/processor class name

Expand Down