Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[roberta] add sdpa to roberta and xlm-roberta #31754

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

kiszk
Copy link
Contributor

@kiszk kiszk commented Jul 2, 2024

What does this PR do?

This PR enables sdpa in RoBERTa and XLM-RoBERTa. Since sdpa is already added to BERT thru #28802, this PR follows that PR.

Tests for RoBERTa are done by the followings at ModelTesterMixin.

  • test_eager_matches_sdpa_generate - test_eager_matches_sdpa_inference_0_float16
  • test_eager_matches_sdpa_inference_0_bfloat16
  • test_eager_matches_sdpa_inference_0_float32

Fixes #31752

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@ArthurZucker @hackyon

@kiszk kiszk changed the title add sdpa to roberta and xlm-roberta [roberta] add sdpa to roberta and xlm-roberta Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suport sdpa for RoBERTa and XLM-RoBERTa models
1 participant