-
Notifications
You must be signed in to change notification settings - Fork 33.9k
Add warning message for beta and gamma parameters #31654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 4 commits
c4c4881
6c830a1
4c931fa
b7b4dad
8e82a85
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1499,6 +1499,49 @@ def test_model_from_pretrained_from_mlx(self): | |
| outputs_from_saved = new_model(input_ids) | ||
| self.assertTrue(torch.allclose(outputs_from_saved["logits"], outputs["logits"])) | ||
|
|
||
| def test_warning_for_beta_gamma_parameters(self): | ||
| class TestModelGamma(PreTrainedModel): | ||
| def __init__(self, config): | ||
| super().__init__(config) | ||
| self.gamma_param = nn.Parameter(torch.ones(10)) | ||
| self.post_init() | ||
|
|
||
| def forward(self): | ||
| return self.gamma_param.sum() | ||
|
|
||
| logger = logging.get_logger("transformers.modeling_utils") | ||
| config = PretrainedConfig() | ||
| warning_msg_gamma = "A parameter name that contains `gamma` will be renamed internally" | ||
| model = TestModelGamma(config) | ||
|
Comment on lines
1514
to
1515
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More importantly, we should check that the parameter is renamed as well
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried this out and it seems that the parameter is not renamed at all. Basically when we load the model using from_pretrained it seems that the parameter is still present with the name
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It shouldn't rename the value in the model, but will rename the value in the state_dict, I believe. Could you dive into the loading logic and verify what's happening?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I tried updating the tests. Could you kindly have a look? |
||
|
|
||
| with tempfile.TemporaryDirectory() as tmp_dir: | ||
| model.save_pretrained(tmp_dir) | ||
| with LoggingLevel(logging.WARNING): | ||
| with CaptureLogger(logger) as cl1: | ||
| TestModelGamma.from_pretrained(tmp_dir, config=config) | ||
|
|
||
| self.assertIn(warning_msg_gamma, cl1.out) | ||
|
|
||
| class TestModelBeta(PreTrainedModel): | ||
| def __init__(self, config): | ||
| super().__init__(config) | ||
| self.beta_param = nn.Parameter(torch.ones(10)) | ||
| self.post_init() | ||
|
|
||
| def forward(self): | ||
| return self.beta_param.sum() | ||
|
|
||
| warning_msg_beta = "A parameter name that contains `beta` will be renamed internally" | ||
| model = TestModelBeta(config) | ||
|
|
||
| with tempfile.TemporaryDirectory() as tmp_dir: | ||
| model.save_pretrained(tmp_dir) | ||
| with LoggingLevel(logging.WARNING): | ||
| with CaptureLogger(logger) as cl2: | ||
| TestModelBeta.from_pretrained(tmp_dir, config=config) | ||
|
|
||
| self.assertIn(warning_msg_beta, cl2.out) | ||
|
|
||
|
|
||
| @slow | ||
| @require_torch | ||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.