Skip to content

[fix bug] logits's shape different from label's shape in preprocess_logits_for_metrics #31447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muellerzr merged 5 commits into from
Jul 3, 2024
Merged

[fix bug] logits's shape different from label's shape in preprocess_logits_for_metrics #31447

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
79fcdf3
[fix BUG] pad labels before use it in preprocess_logits_for_metrics
wiserxin Jun 17, 2024
7aab5ef
a more readable fix
wiserxin Jun 18, 2024
91d3349
Merge branch 'huggingface:main' into main
wiserxin Jun 18, 2024
376eb0c
add a comment
wiserxin Jun 19, 2024
fe59a9a
oh code quality check
wiserxin Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/transformers/trainer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3822,6 +3822,9 @@ def evaluation_loop(
inputs_decode = self.gather_function((inputs_decode))
if not self.args.batch_eval_metrics or description == "Prediction":
all_inputs.add(inputs_decode)
if labels is not None:
# Pad labels here, preparing for preprocess_logits_for_metrics in next logits block.
labels = self.accelerator.pad_across_processes(labels, dim=1, pad_index=-100)
if logits is not None:
logits = self.accelerator.pad_across_processes(logits, dim=1, pad_index=-100)
if self.preprocess_logits_for_metrics is not None:
Expand All @@ -3830,7 +3833,6 @@ def evaluation_loop(
if not self.args.batch_eval_metrics or description == "Prediction":
all_preds.add(logits)
if labels is not None:
labels = self.accelerator.pad_across_processes(labels, dim=1, pad_index=-100)
labels = self.gather_function((labels))
if not self.args.batch_eval_metrics or description == "Prediction":
all_labels.add(labels)
Expand Down