Skip to content

FIX / Quantizaiton: Revert back previous replacement logic #30779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
younesbelkada wants to merge 1 commit into from
Closed

FIX / Quantizaiton: Revert back previous replacement logic #30779

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/transformers/integrations/bitsandbytes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,8 +157,13 @@ def _replace_with_bnb_linear(
if (isinstance(module, nn.Linear) or isinstance(module, Conv1D)) and name not in modules_to_not_convert:
# Check if the current key is not in the `modules_to_not_convert`
current_key_name_str = ".".join(current_key_name)

# Here we keep the `key in ".".join(current_key_name)` condition for backward compatibility
if not any(
(key + "." in current_key_name_str) or (key == current_key_name_str) for key in modules_to_not_convert
(key + "." in current_key_name_str)
or (key == current_key_name_str)
or (key in ".".join(current_key_name))
Copy link
Member

@BenjaminBossan BenjaminBossan May 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use current_key_name_str here?

for key in modules_to_not_convert
):
with init_empty_weights():
if isinstance(module, Conv1D):
Expand Down