Skip to content

Fix WhisperForConditionalGeneration to respect generation_config? #30623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mizoru wants to merge 2 commits into from
Closed

Fix WhisperForConditionalGeneration to respect generation_config? #30623

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0afe4c2
Fix WhisperGenerationMixin._set_return_timestamps for return_timestam…
mizoru Apr 30, 2024
579743d
Merge branch 'huggingface:main' into main
mizoru May 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/transformers/models/whisper/generation_whisper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1042,8 +1042,8 @@ def _set_return_timestamps(return_timestamps, is_shortform, generation_config):
"Make sure to initialize the generation config with the correct attributes that are needed such as `no_timestamps_token_id`. "
"For more details on how to generate the approtiate config, refer to https://github.com/huggingface/transformers/issues/21878#issuecomment-1451902363"
)

generation_config.return_timestamps = return_timestamps
if return_timestamps is not None:
generation_config.return_timestamps = return_timestamps

@staticmethod
def _set_language_and_task(language, task, is_multilingual, generation_config):
Expand Down