Fix test transposing image with EXIF Orientation tag#30319
Merged
amyeroberts merged 2 commits intohuggingface:mainfrom Apr 18, 2024
Merged
Fix test transposing image with EXIF Orientation tag#30319amyeroberts merged 2 commits intohuggingface:mainfrom
amyeroberts merged 2 commits intohuggingface:mainfrom
Conversation
2 tasks
lhoestq
reviewed
Apr 18, 2024
Member
lhoestq
left a comment
There was a problem hiding this comment.
Maybe fix the test by using PIL.Image to load the image from its URL instead of datasets ? It's a bit weird to rely on datasets to test the load_image function
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Member
Author
|
I think it makes sense. As there are 4 tests using |
Member
Author
|
@huggingface/transformers we need this PR to be merged before we can make the |
lhoestq
approved these changes
Apr 18, 2024
ydshieh
pushed a commit
that referenced
this pull request
Apr 23, 2024
* Fix test with exif_transpose image * Replace datasets with PIL to load image in tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes issue transposing image with EXIF Orientation tag due to a change in the
datasetslibrary that will be included in the 2.19.0 release. See:Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.