Skip to content

Conversation

@qubvel
Copy link
Contributor

@qubvel qubvel commented Apr 17, 2024

What does this PR do?

Close the issue with token2json processing method for Donut

There is a bug in the implementation of the function token2json in the DonutProcessor class. It doesn't work when there are multilines in a value as shown in the example below. It is related the regex code.

Fixes # (issue)
#30272

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@qubvel
Copy link
Contributor Author

qubvel commented Apr 17, 2024

@NielsRogge could you please review, as you added this model

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing so quickly!

Reviewing as I think @NielsRogge is off today

@amyeroberts amyeroberts merged commit 7915a25 into huggingface:main Apr 18, 2024
ydshieh pushed a commit that referenced this pull request Apr 23, 2024
* Fix multiline processing

* Update test for token2json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants