(Docs) Fix object_detection.md: Do not convert from RGB to BGR for augmentations #30180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docs of Albumenations here explicitly mention that they use RGB instead of BGR: https://albumentations.ai/docs/examples/example/#read-the-image-from-the-disk-and-convert-it-from-the-bgr-color-space-to-the-rgb-color-space This line of code however reverses the color channel dimensions after opening the image as RGB.
Author
|
@NielsRogge tagging you for a review here as you're the most recent contributor to the doc and if I'm not wrong its original author. |
Contributor
|
cc @qubvel could you take a look here? |
Author
Contributor
|
@rootAvish Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The docs of Albumenations here say that they use RGB instead of BGR: https://albumentations.ai/docs/examples/example/#read-the-image-from-the-disk-and-convert-it-from-the-bgr-color-space-to-the-rgb-color-space
The object detection notebook/docs however reverse the color channel dimension after opening the image as RGB and therefore pass BGR. My PR removes the reversal of channel dimension to correct this.
Before submitting
Pull Request section?