Skip to content

Make clearer about zero_init requirements #29879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
muellerzr merged 8 commits into from
Apr 3, 2024
Merged

Make clearer about zero_init requirements #29879

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
b47f8f1
Docstring to note about zero init
muellerzr Mar 26, 2024
0234833
Check for accelerate
muellerzr Mar 26, 2024
125cd16
Change conditional return
muellerzr Mar 26, 2024
eb122c7
Tweak
muellerzr Mar 26, 2024
e455bc6
Add new accelerate-specific zero3 check
muellerzr Mar 28, 2024
93ff7e7
Fix import
muellerzr Mar 28, 2024
5c2370b
Revert to RTFM
muellerzr Apr 2, 2024
1740e29
Update src/transformers/modeling_utils.py
muellerzr Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/transformers/training_args.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -503,6 +503,11 @@ class TrainingArguments:
evolve in the future. The value is either the location of DeepSpeed json config file (e.g.,
`ds_config.json`) or an already loaded json file as a `dict`"

<Tip warning={true}>
If enabling any Zero-init, make sure that your model is not initialized until
*after* initializing the `TrainingArguments`, else it will not be applied.
</Tip>

accelerator_config (`str`, `dict`, or `AcceleratorConfig`, *optional*):
Config to be used with the internal `Accelerator` implementation. The value is either a location of
accelerator json config file (e.g., `accelerator_config.json`), an already loaded json file as `dict`,
Expand Down