fix galore layerwise with frozen params #29743
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
younesbelkada
approved these changes
Mar 20, 2024
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Nice catch thanks !
Contributor
|
@peterjc123 can you run the styling checks? |
Contributor
Author
|
@younesbelkada Done. |
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks ! Hmmm many undesired files have been modified, can you try to pip install -U ".[quality]" to make sure you have the same ruff version as us and re-run make fixup again?
Contributor
Author
|
@younesbelkada Should be okay this time. |
amyeroberts
approved these changes
Mar 20, 2024
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
Thanks for the quick fix!
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
ArthurZucker
pushed a commit
that referenced
this pull request
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.