Move misplaced line #29117
Merged
Move misplaced line #29117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move misplaced line, improve code comment
younesbelkada
approved these changes
Feb 20, 2024
Contributor
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks so much for the nit !
| shift_logits = shift_logits.view(-1, self.config.vocab_size) | ||
| shift_labels = shift_labels.view(-1) | ||
| # Enable model parallelism | ||
| # Ensure tensors are on the same device |
Contributor
There was a problem hiding this comment.
Suggested change
| # Ensure tensors are on the same device | |
| # Ensure that tensors are on the same device |
ArthurZucker
approved these changes
Feb 20, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move misplaced line, improve code comment.
No functional change, the loss_fct is not used earlier and did not match the code comment either.
Before submitting
Who can review?
@ArthurZucker and @younesbelkada