-
Notifications
You must be signed in to change notification settings - Fork 32.6k
Implementation of SuperPoint and AutoModelForKeypointDetection #28966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
amyeroberts
merged 39 commits into
huggingface:main
from
sbucaille:add_superpoint_fixed
Mar 19, 2024
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
f2c4485
Added SuperPoint docs
c94e87e
Added tests
3064044
Removed commented part
c72f85b
Commit to create and fix add_superpoint branch with a new branch
b4b7de2
Fixed dummy_pt_objects
7d51c10
Committed missing files
482f9df
Fixed README.md
743b944
Apply suggestions from code review
sbucaille a8c9691
Moved ImagePointDescriptionOutput from modeling_outputs.py to modelin…
6a53561
Removed AutoModelForKeypointDetection and related stuff
01b35e2
Fixed inconsistencies in image_processing_superpoint.py
cf8fa21
Moved infer_on_model logic simply in test_inference
95737eb
Fixed bugs, added labels to forward method with checks whether it is …
d00f131
Added tests to SuperPointImageProcessor to ensure that images are pro…
9e22f01
Removed remaining mentions of MODEL_FOR_KEYPOINT_DETECTION_MAPPING
00d2631
Apply suggestions from code review
sbucaille 05fa24c
Fixed from (w, h) to (h, w) as input for tests
f1de78a
Removed unnecessary condition
4beb1f6
Moved last_hidden_state to be the first returned
032ee01
Moved last_hidden_state to be the first returned (bis)
1050cf2
Moved last_hidden_state to be the first returned (ter)
9c7d8b4
Switched image_width and image_height in tests to match recent changes
f6c0ff1
Added config as first SuperPointConvBlock init argument
9318461
Reordered README's after merge
71d8855
Added missing first config argument to SuperPointConvBlock instantiat…
fe260fb
Removed formatting error
7101b4e
Added SuperPoint to README's de, pt-br, ru, te and vi
e3bb113
Checked out README_fr.md
6814b4b
Fixed README_fr.md
55b40a9
Test fix README_fr.md
514331e
Test fix README_fr.md
7b3cc88
Last make fix-copies !
bc1ee3f
Updated checkpoint path
155f977
Removed unused SuperPoint doc
9c9501c
Added missing image
1c58ab4
Update src/transformers/models/superpoint/modeling_superpoint.py
sbucaille 92c9e8e
Removed unnecessary import
0a99b5c
Update src/transformers/models/superpoint/modeling_superpoint.py
sbucaille 45c25c6
Added SuperPoint to _toctree.yml
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.