Set cache_dir for evaluate.load() in example scripts#28422
Merged
Conversation
While using `run_clm.py`,[^1] I noticed that some files were being added to my global cache, not the local cache. I set the `cache_dir` parameter for the one call to `evaluate.load()`, which partially solved the problem. I figured that while I was fixing the one script upstream, I might as well fix the problem in all other example scripts that I could. There are still some files being added to my global cache, but this appears to be a bug in `evaluate` itself. This commit at least moves some of the files into the local cache, which is better than before. To create this PR, I made the following regex-based transformation: `evaluate\.load\((.*?)\)` -> `evaluate\.load\($1, cache_dir=model_args.cache_dir\)`. After using that, I manually fixed all modified files with `ruff` serving as useful guidance. During the process, I removed one existing usage of the `cache_dir` parameter in a script that did not have a corresponding `--cache-dir` argument declared. [^1]: I specifically used `pytorch/language-modeling/run_clm.py` from v4.34.1 of the library. For the original code, see the following URL: https://github.com/huggingface/transformers/tree/acc394c4f5e1283c19783581790b3dc3105a3697/examples/pytorch/language-modeling/run_clm.py.
Contributor
Author
|
I would appreciate if you could make sure to preserve my commit message (with any needed changes) when merging so it ends up in the Git log. |
ArthurZucker
approved these changes
Jan 11, 2024
Collaborator
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks! This is silent and makes sense! 🤗
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
While using
run_clm.py,1 I noticed that some files were being added to my global cache, not the local cache. I set thecache_dirparameter for the one call toevaluate.load(), which partially solved the problem. I figured that while I was fixing the one script upstream, I might as well fix the problem in all other example scripts that I could.There are still some files being added to my global cache, but this appears to be a bug in
evaluateitself. This commit at least moves some of the files into the local cache, which is better than before.To create this PR, I made the following regex-based transformation:
evaluate\.load\((.*?)\)->evaluate\.load\($1, cache_dir=model_args.cache_dir\). After using that, I manually fixed all modified files withruffserving as useful guidance. During the process, I removed one existing usage of thecache_dirparameter in a script that did not have a corresponding--cache-dirargument declared.Who can review?
Maintained examples:
Footnotes
I specifically used
pytorch/language-modeling/run_clm.pyfrom v4.34.1 of the library. For the original code, see the following URL: https://github.com/huggingface/transformers/tree/acc394c4f5e1283c19783581790b3dc3105a3697/examples/pytorch/language-modeling/run_clm.py. ↩