add test marker to run all tests with @require_bitsandbytes#28278
add test marker to run all tests with @require_bitsandbytes#28278younesbelkada merged 1 commit intohuggingface:mainfrom
Conversation
|
Submitting this as a separate PR, to keep things clean/atomic. |
younesbelkada
left a comment
There was a problem hiding this comment.
Awesome, works for me, thanks a lot @Titus-von-Koeller !
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks again ! Note to effectively run bnb tests it is sufficient to just run RUN_SLOW=1 pytest tests/quantization/bnb as running pytest -m bitsandbytes tests/ will run other tests such as tests that we put on llama etc which are already covered in tests/quantization/bnb, but this is a good addition anyway so I'd be keen to merge the PR
ArthurZucker
left a comment
There was a problem hiding this comment.
Thanks! let's just keep the same format for the markers
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
Really strange, I just committed the marker description string change that @ArthurZucker suggested, but the tests are failing with unrelated stuff. Maybe the GH Runner doesn't have the right hardware for those tests? |
|
Yes it's unrelated to your PR don't worry! |
|
rebasing on main should suffice to fix this ! |
4fbfa32 to
38a1989
Compare
younesbelkada
left a comment
There was a problem hiding this comment.
cc @ArthurZucker @ydshieh the CI runner is still failing - I think it uses the former cache that has the un-compatible naten library installed - #28432 IMO we can move forward and merge
|
Hmm it seems to fail on other PRs too, e.g. :#28711 |
|
don't have good idea. i just re-triggered that job and let's see |
38a1989 to
c979585
Compare
What does this PR do?
add test marker to run all tests with @require_bitsandbytes
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@younesbelkada, do I need any documentation for this and if yes, where?