Skip to content

Conversation

@izyForever
Copy link
Contributor

@izyForever izyForever commented Dec 21, 2023

What does this PR do?

Update the logger message with accordant weights_file_name.

Fixes # (issue)
#28076

@amyeroberts

@izyForever
Copy link
Contributor Author

izyForever commented Dec 21, 2023

@amyeroberts

I can't figure out why I failed the tests_torch for I only changed the logger info.😖

)6)H WRK7EVWMBBDTCFV 8

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this and contributing to improving the code!

For the failing (unrelated) tests, there was a fix merge into main recently - #28202. Could you rebase and push the updated branch? This should resolve and trigger another CI run

@izyForever
Copy link
Contributor Author

izyForever commented Dec 22, 2023

Thanks for updating this and contributing to improving the code!

For the failing (unrelated) tests, there was a fix merge into main recently - #28202. Could you rebase and push the updated branch? This should resolve and trigger another CI run

@amyeroberts It works!It seems the workflow need extra approval to finish merge.

@amyeroberts
Copy link
Contributor

amyeroberts commented Dec 22, 2023

@izyForever Yes - the doc tests aren't automatically run for security reasons. I've approved the workflow now - once that passes I'll merge in.

Thanks again for your contribution!

@amyeroberts amyeroberts merged commit 68fa1e8 into huggingface:main Dec 22, 2023
Saibo-creator pushed a commit to epfl-dlab/transformers-GCD-PR that referenced this pull request Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants