Skip to content

[dependency] update pillow pins #27409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ArthurZucker merged 10 commits into from
Nov 22, 2023
Merged

[dependency] update pillow pins #27409

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
dbb6ef2
update pillow pins
ArthurZucker Nov 9, 2023
f7c7d99
Merge branch 'main' of github.com:huggingface/transformers into updat…
ArthurZucker Nov 10, 2023
4055901
Merge branch 'main' of github.com:huggingface/transformers into updat…
ArthurZucker Nov 13, 2023
e7be0a0
Apply suggestions from code review
ArthurZucker Nov 13, 2023
1863e15
Merge branch 'main' of github.com:huggingface/transformers into updat…
ArthurZucker Nov 15, 2023
390460a
Merge branch 'update-pillow' of github.com:huggingface/transformers i…
ArthurZucker Nov 15, 2023
b0811ba
more freedomin pins
ArthurZucker Nov 16, 2023
2f43541
Merge branch 'main' of github.com:huggingface/transformers into updat…
ArthurZucker Nov 16, 2023
6eb268b
Merge branch 'main' of github.com:huggingface/transformers into updat…
ArthurZucker Nov 20, 2023
056f5bc
Merge branch 'update-pillow' of github.com:huggingface/transformers i…
ArthurZucker Nov 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
# 1. all dependencies should be listed here with their version requirements if any
# 2. once modified, run: `make deps_table_update` to update src/transformers/dependency_versions_table.py
_deps = [
"Pillow<10.0.0",
"Pillow>=10.0.1,<=11.0",

@amyeroberts amyeroberts Nov 15, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why <=11.0?

@ArthurZucker ArthurZucker Nov 15, 2023

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll pin <=15.0, it's just to not allow whatever!
Thanks for the tips will run the slow model tests 😉

@ArthurZucker ArthurZucker Nov 16, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Vit
  • Clip
  • Detr (tests/models/detr/test_modeling_detr.py::DetrModelIntegrationTestsTimmBackbone::test_inference_panoptic_segmentation_head fails:
E       - {'id': 1, 'label_id': 17, 'score': 0.994097, 'was_fused': False}
E       ?                                           ^
E       
E       + {'id': 1, 'label_id': 17, 'score': 0.994096, 'was_fused': False}

Might be my arch rather than anything

  • SAM

Which models would you think rely a lot on pillow version that I should test as well?

@amyeroberts amyeroberts Nov 16, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that difference is definitely in the realm of acceptable!

All vision models rely on Pillow for their processing. I picked these models to cover different default resampling algos + popular models on different tasks. AFAICT - there's just bicubic, bilinear and nearest used for resizing settings and they've all been tested :)

"accelerate>=0.20.3",
"av==9.2.0", # Latest version of PyAV (10.0.0) has issues with audio stream.
"beautifulsoup4",
Expand Down
2 changes: 1 addition & 1 deletion src/transformers/dependency_versions_table.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# 1. modify the `_deps` dict in setup.py
# 2. run `make deps_table_update``
deps = {
"Pillow": "Pillow<10.0.0",
"Pillow": "Pillow>=10.0.1,<=11.0",
"accelerate": "accelerate>=0.20.3",
"av": "av==9.2.0",
"beautifulsoup4": "beautifulsoup4",
Expand Down