-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Fix TensorFlow pakage check #26842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix TensorFlow pakage check #26842
Conversation
|
Taking this one! |
|
Hey @jayfurmanek, I checked this out! Adding Update: Part of the issue might be that |
b4a270b to
ed00104
Compare
|
The problem with the check as-is is that it does _is_package_available() with "tensorflow" and then does the meta data check there as well. For tensorflow-rocm that part will fail and _is_available will be marked as False, so the candidates list below is skipped altogether. |
ed00104 to
9624f2d
Compare
|
Hi @jayfurmanek I just tested locally and installing with |
|
@jayfurmanek I confirmed after installing one of those wheels that just adding |
|
If you want to test it yourself, you can run |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. |
9624f2d to
d58d5a7
Compare
|
I was using thx |
|
Yeah, that code is a little wonky, and we'll have to do a proper refactor eventually. I think this resolves the issue here for now, though, so thanks for the PR! |
Add tf-nightly-rocm to _is_tf_available check
What does this PR do?
This fixes the
_is_package_availablecheck for tensorflow variants (like tensorflow-rocm) where their meta-data differs from the package name. There is an list of available candidate names there, but they are never used since_is_package_availablewill return false preventing the candidate list from being checked.This also adds
tf-nightly-rocmto the list of candidates.Fixes # (issue)
N/A
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
This fixes a small functional error, no documentation updates are required.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.