-
Notifications
You must be signed in to change notification settings - Fork 31.7k
[docs] Update to scripts building index.md #26546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice, I think it's a lot cleaner like this! ✨
It looks like some models (like Llama 2, Flan T5, DiT) are missing though.
ArthurZucker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very clean thanks a lot 🤗
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is a good time to check model on the table has a corresponding model.md and vice-versa!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe check_copies.py checks consistency between model.md and the list of models in MODEL_NAMES_MAPPING. Here, I use the same MODEL_NAMES_MAPPING, so I'm not sure one more check here is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if you think it's good to merge as is. Sorry about the ping @ArthurZucker :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A loooooot better indeed 😉
The reason they are missing is that the table is based on the model classes. And in case of the models you mentioned, Llama 2 uses the same implementation as Llama, Flan T5 uses the same implementation as T5, and DiT's architecture is equivalent to that of BEiT. |
|
Yep, I think these models should be part of the table and we should make sure we can easily add more models there that share the same modeling file! |
|
I've added a dict of models that use the same config as some "base" model. This way the table is complete. cc @stevhliu |
stevhliu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, and thanks for completing the table!
The
docs/index.mdfile currently contains two auto-generated parts: the list of models (same as in README), and a table of models with supported frameworks. Due to the number of models available in transformers (200+), the list and the table have become quite large, and there have been internal discussions about removing the list of models from theindex.md.This PR adds the following changes:
index.mdand updates the script so it's no longer addedThe model lists in the main README and localized READMEs remain as is.