[Falcon] Set use_cache=False before creating presents which relies on use_cache

[yundai424]

What does this PR do?

Fixes #26327

Before submitting

• This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
• [X ] Did you read the contributor guideline,
  Pull Request section?
• [ X] Was this discussed/approved via a Github issue or the forum? Please add a link
  to it if that's the case.
• [X ] Did you make sure to update the documentation with your changes? Here are the
  documentation guidelines, and
  here are tips on formatting docstrings.
• Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

• text models: @ArthurZucker and @younesbelkada

[ArthurZucker]

That's a good catch!

[ArthurZucker]

This should be done outside the loop and similar to this:

        if self.gradient_checkpointing and self.training:
            if use_cache:
                logger.warning_once(
                    "`use_cache=True` is incompatible with gradient checkpointing. Setting `use_cache=False`..."
                )
                use_cache = False

        present_key_values = () if use_cache else None
        all_self_attentions = () if output_attentions else None
        all_hidden_states = () if output_hidden_states else None

[yundai424]

updated, thanks!

[younesbelkada]

Great catch ! Can you run the styling checks?

make fixup

Then we can merge I think

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

[younesbelkada]

Hi @yundai424 thanks a lot for iterating, in order to move forward with the PR could you merge your branch with main branch?

[yundai424]

Hi @younesbelkada are you referring to merging to HF main? 🤔

[younesbelkada]

Hi @yundai424
I meant to merge your local branch with HF's main branch, assuming the hf remote is tagged as upstream (you can also add it with git remote add upstream https://github.com/huggingface/transformers.git)

git fetch upstream
git merge upstream/main
git push

[yundai424]

oh cool i see what you mean.. merged, thanks! @younesbelkada

[younesbelkada]

Clean to me, thanks!

[LysandreJik]

Great, thanks @yundai424!