Update logits_process.py docstrings to clarify penalty and reward cases #26129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added docstrings to clarify the reward aspect of `RepetitionPenaltyLogitsProcessor` and `EncoderRepetitionPenaltyLogitsProcessor`
gante
reviewed
Sep 13, 2023
Contributor
gante
left a comment
gante
left a comment
There was a problem hiding this comment.
Thank you for the clarifications! A few suggestions :)
Contributor
Author
|
Hey @gante @ArthurZucker! This is ready for review 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes point 3 of #25970 by clarifying the penalty and reward cases for
RepetitionPenaltyLogitsProcessorandEncoderRepetitionPenaltyLogitsProcessorwithin the docstrings.EncoderRepetitionPenaltyLogitsProcessormay require further iterations as the class name does not accurately reflect what the class is doing.@gante