Skip to content

Conversation

@susnato
Copy link
Contributor

@susnato susnato commented Aug 29, 2023

What does this PR do?

The remaining files are transferred to the original Pop2Piano repository on HuggingFace Hub (PR link).
This PR updates all the remaining checkpoints.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

Copy link
Contributor

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint.

@amyeroberts
Copy link
Contributor

@susnato Am I OK to merge this - or are there other changes you'd like to push beforehand?

@susnato
Copy link
Contributor Author

susnato commented Aug 29, 2023

We can merge this.

BTW later this week I will update the pop2piano demo to use the transformers and also add some features to the space, is it a good idea to also add that at the end of the pop2piano.md file once it is finished, so we can showcase this model in a easier and interactive way?

@amyeroberts
Copy link
Contributor

@susnato Great - yes, it'd be great to add examples for the model! For a spaces demo, this is normally added as a badge on the page e.g. like this for XLNet, and corresponding doc page.

@amyeroberts amyeroberts merged commit 0e59c93 into huggingface:main Aug 29, 2023
@susnato susnato mentioned this pull request Sep 5, 2023
5 tasks
parambharat pushed a commit to parambharat/transformers that referenced this pull request Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants