Skip to content

Conversation

@amyeroberts
Copy link
Contributor

What does this PR do?

Updates the default value for rescale_factor in line with the updates that happened in #25174 and in the model's checkpoints on the hub 1, 2

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Copy link
Collaborator

@ydshieh ydshieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Aug 16, 2023

The documentation is not available anymore as the PR was closed or merged.

Copy link
Collaborator

@ArthurZucker ArthurZucker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the prompt fix !

@amyeroberts amyeroberts changed the title 🚨🚨🚨 Update default rescale_factor value 🚨🚨🚨 Vivit update default rescale_factor value Aug 17, 2023
@amyeroberts amyeroberts merged commit c8346cb into huggingface:main Aug 17, 2023
@amyeroberts amyeroberts deleted the fix-vivit-image-processor-rescale-default branch August 17, 2023 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants