Skip to content

Fallback for missing attribute Parameter.ds_numel #24942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 2 commits into from
Jul 20, 2023
Merged

Fallback for missing attribute Parameter.ds_numel #24942

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d1e10c0
[trainer] fallback for deepspeed param count
apoorvkh Jul 20, 2023
0131e86
[trainer] more readable numel count
apoorvkh Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions src/transformers/trainer_pt_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,17 +1040,19 @@ def get_model_param_count(model, trainable_only=False):
"""
Calculate model's total param count. If trainable_only is True then count only those requiring grads
"""
if is_deepspeed_zero3_enabled():
zero3_enabled = is_deepspeed_zero3_enabled()
total_params = 0

def numel(p):
return p.ds_numel
for p in model.parameters():
if trainable_only and p.requires_grad is False:
continue

else:

def numel(p):
return p.numel()
if zero3_enabled and hasattr(p, "ds_numel"):
total_params += p.ds_numel
else:
total_params += p.numel()

return sum(numel(p) for p in model.parameters() if not trainable_only or p.requires_grad)
return total_params


def get_parameter_names(model, forbidden_layer_types):
Expand Down