Skip test_multi_gpu_data_parallel_forward for MobileViTV2ModelTest#24017
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
amyeroberts
approved these changes
Jun 5, 2023
amyeroberts
left a comment
amyeroberts
left a comment
Contributor
There was a problem hiding this comment.
Thanks for fixing!
Do you know if this happens with any other models? It would be good to keep track in case there's something in the architecture design we need to be careful about.
Collaborator
Author
|
Yes, see #21991. That PR mentioned torch 2.0, but this test are skipped for some other modes even before that PR for other reasons. |
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
huggingface#24017) * fix * fix * fix --------- Co-authored-by: ydshieh <ydshieh@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Skip
test_multi_gpu_data_parallel_forwardforMobileViTV2ModelTest.This passes on CI, but the other 2x tests running after this one are all failing with
CUDA error: misaligned address.(Similar to #21991)