improve(llama): Faster apply_rotary_pos_emb #22785
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
gante
approved these changes
Apr 17, 2023
Contributor
There was a problem hiding this comment.
Thanks for improving the performance @fpgaminer 🙏
@amyeroberts for context, this comment shows that a) it gets exactly the same numerical output b) it is faster than the previous version
amyeroberts
approved these changes
Apr 17, 2023
Contributor
amyeroberts
left a comment
amyeroberts
left a comment
There was a problem hiding this comment.
🔥 🔥 🔥 - thanks for updating and for the time to validate and benchmark 🙏
5 tasks
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
|
Should a similar patch be applied to GPT-NeoX? |
Contributor
|
@neggert I believe it can be added to GPT-NeoX too - very happy to review a PR if you'd like to add! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Faster implementation for
apply_rotary_pos_embinmodeling_llama.py.Please see issue #22683 for code that verifies the correctness of the change.
NOTE: Not marking as fixing the above issue, as speed is still not as good as before.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@gante