Skip to content

Move labels to the same device as logits for LlamaForSequenceClassification and Blip2#22596

Merged
sgugger merged 5 commits into
huggingface:mainfrom
xssChauhan:llama_seqclassification_parllelism
Apr 7, 2023
Merged

Move labels to the same device as logits for LlamaForSequenceClassification and Blip2#22596
sgugger merged 5 commits into
huggingface:mainfrom
xssChauhan:llama_seqclassification_parllelism

Conversation

@xssChauhan

@xssChauhan xssChauhan commented Apr 5, 2023

Copy link
Copy Markdown
Contributor

What does this PR do?

Fixes issue #22561 by moving the labels to the same device as the logits they are compared to for LlamaForSequenceClassification, Blip2.

@sgugger Could you review this once?

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 5, 2023

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@sgugger sgugger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR but it seems there is an issue with your CircleCI permissions, the tests won't run.
Could you try refreshing your permissions as shown here?

@xssChauhan

Copy link
Copy Markdown
Contributor Author

@sgugger I have refreshed my permissions, but I still do not see the option of rerunning the pipeline on CircleCI. Is it possible that I cant do that?

@sgugger

sgugger commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

You can just push an empty commit: git commit -m "Trigger CI" --allow-empty

@xssChauhan

Copy link
Copy Markdown
Contributor Author

@sgugger Is such a long waiting time for CircleCI report expected?

@sgugger

sgugger commented Apr 6, 2023

Copy link
Copy Markdown
Collaborator

Could you try again? Tests still aren't run.

@xssChauhan xssChauhan force-pushed the llama_seqclassification_parllelism branch from 824de2e to 320e7cc Compare April 6, 2023 22:06
@xssChauhan xssChauhan changed the title Move labels to the same device as logits for LlamaForSequenceClassification Move labels to the same device as logits for LlamaForSequenceClassification and Blip2 Apr 6, 2023
@xssChauhan

xssChauhan commented Apr 7, 2023

Copy link
Copy Markdown
Contributor Author

@sgugger I also added code for Blip2, and the tests now pass.

@xssChauhan xssChauhan requested a review from sgugger April 7, 2023 10:00
@sgugger

sgugger commented Apr 7, 2023

Copy link
Copy Markdown
Collaborator

Perfect, thanks!

@sgugger sgugger merged commit 1de8ce9 into huggingface:main Apr 7, 2023
xloem pushed a commit to xloem/transformers that referenced this pull request Apr 10, 2023
…cation and Blip2 (huggingface#22596)

* (feat): Move labels to the same device as logits

* Trigger CI

* Trigger CI

* Trigger CI

* (feat): Making changes for Blip2
novice03 pushed a commit to novice03/transformers that referenced this pull request Jun 23, 2023
…cation and Blip2 (huggingface#22596)

* (feat): Move labels to the same device as logits

* Trigger CI

* Trigger CI

* Trigger CI

* (feat): Making changes for Blip2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants