Correct NATTEN function signatures and force new version#22298
Merged
Conversation
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Unsure why a Flax test is failing. I'm assuming I'll have to wait for another PR to merge and then rebase? |
Collaborator
|
Hi, Thank you for the fix and PR. Regarding failing flax test, you can ignore it🤗 |
Collaborator
|
This is needed to fix the CI on the main branch (broken by the new release of |
5 tasks
raghavanone
pushed a commit
to raghavanone/transformers
that referenced
this pull request
Apr 5, 2023
alihassanijr
pushed a commit
to alihassanijr/StyleNAT
that referenced
this pull request
Apr 5, 2023
NATTEN functions take in kernel size as well as dilation since 0.14.6. The change in signature breaks Hydra-NA, which calls those functions directly instead of using the nn.Module. This fixes SHI-Labs#8 . Refs: * https://github.com/SHI-Labs/NATTEN/releases/tag/v0.14.6 * https://github.com/SHI-Labs/NATTEN/blob/main/CHANGELOG.md#0146---2023-03-21 Same change in other repositories using NATTEN: * huggingface/transformers#22229 * huggingface/transformers#22298
novice03
pushed a commit
to novice03/transformers
that referenced
this pull request
Jun 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This complements #22229. (Sorry for breaking it into two; I was traveling when I realized the issue so I only started a quick PR to fix circleci builds.)
We're releasing a new NATTEN build that corrects the signature inconsistency between the function calls (see my comment in the previous PR for more.)
Rather than wait for a future build, we decided to do it right now because we could end up forgetting to open a PR to transformers.
We're finishing up testing the new build, but I figured I'd open this PR before I push to PyPI. If circleci tries to get the latest version from PyPI it would fail the unit tests associated with models depending on this package.
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
@ydshieh @amyeroberts @sgugger