-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Add a new script to check model testers' config #22063
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,63 @@ | ||
| # coding=utf-8 | ||
| # Copyright 2023 The HuggingFace Inc. team. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
|
|
||
| import glob | ||
| import os | ||
|
|
||
| from get_test_info import get_tester_classes | ||
|
|
||
|
|
||
| if __name__ == "__main__": | ||
| failures = [] | ||
|
|
||
| pattern = os.path.join("tests", "models", "**", "test_modeling_*.py") | ||
| test_files = glob.glob(pattern) | ||
| # TODO: deal with TF/Flax too | ||
| test_files = [ | ||
| x for x in test_files if not (x.startswith("test_modeling_tf_") or x.startswith("test_modeling_flax_")) | ||
| ] | ||
|
|
||
| for test_file in test_files: | ||
| tester_classes = get_tester_classes(test_file) | ||
| for tester_class in tester_classes: | ||
| # A few tester classes don't have `parent` parameter in `__init__`. | ||
| # TODO: deal this better | ||
| try: | ||
| tester = tester_class(parent=None) | ||
| except Exception: | ||
| continue | ||
| if hasattr(tester, "get_config"): | ||
| config = tester.get_config() | ||
| for k, v in config.to_dict().items(): | ||
| if isinstance(v, int): | ||
| target = None | ||
| if k in ["vocab_size"]: | ||
| target = 100 | ||
| elif k in ["max_position_embeddings"]: | ||
| target = 128 | ||
| elif k in ["hidden_size", "d_model"]: | ||
| target = 40 | ||
| elif k == ["num_layers", "num_hidden_layers", "num_encoder_layers", "num_decoder_layers"]: | ||
| target = 5 | ||
| if target is not None and v > target: | ||
| failures.append( | ||
ydshieh marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| f"{tester_class.__name__} will produce a `config` of type `{config.__class__.__name__}`" | ||
| f' with config["{k}"] = {v} which is too large for testing! Set its value to be smaller' | ||
| f" than {target}." | ||
| ) | ||
|
|
||
| if len(failures) > 0: | ||
| raise Exception(f"There were {len(failures)} failures:\n" + "\n".join(failures)) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just check a few most well known attributes (for now).