Skip to content

Add a progress bar for the total download of shards #22062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sgugger merged 3 commits into from
Mar 9, 2023
Merged

Add a progress bar for the total download of shards #22062

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
98fee77
Add a progress bar for the total download of shards
sgugger Mar 9, 2023
aa02a9d
Check for no cache at all
sgugger Mar 9, 2023
e170aba
Fix check
sgugger Mar 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/transformers/models/detr/configuration_detr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,6 +239,7 @@ def hidden_size(self) -> int:
@classmethod
def from_backbone_config(cls, backbone_config: PretrainedConfig, **kwargs):
"""Instantiate a [`DetrConfig`] (or a derived class) from a pre-trained backbone model configuration.

Args:
backbone_config ([`PretrainedConfig`]):
The backbone configuration.
Expand Down
10 changes: 8 additions & 2 deletions src/transformers/utils/hub.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ def cached_file(
if isinstance(cache_dir, Path):
cache_dir = str(cache_dir)

if _commit_hash is not None:
if _commit_hash is not None and not force_download:
Copy link
Copy Markdown
Member

@LysandreJik LysandreJik Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch :)

# If the file is cached under that commit hash, we return it directly.
resolved_file = try_to_load_from_cache(
path_or_repo_id, full_filename, cache_dir=cache_dir, revision=_commit_hash
Expand Down Expand Up @@ -913,7 +913,13 @@ def get_checkpoint_shard_files(

# At this stage pretrained_model_name_or_path is a model identifier on the Hub
cached_filenames = []
for shard_filename in shard_filenames:
# Check if the model is already cached or not. We only try the last checkpoint, this should cover most cases of
# downloaded (if interrupted).
last_shard = try_to_load_from_cache(
pretrained_model_name_or_path, shard_filenames[-1], cache_dir=cache_dir, revision=_commit_hash
)
show_progress_bar = last_shard is None or force_download
for shard_filename in tqdm(shard_filenames, desc="Downloading shards", disable=not show_progress_bar):
try:
# Load from URL
cached_filename = cached_file(
Expand Down