Skip to content

[Blip] Fix blip doctest #21868

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
younesbelkada merged 1 commit into from
Mar 1, 2023
Merged

[Blip] Fix blip doctest #21868

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/transformers/models/blip/modeling_blip.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -985,8 +985,9 @@ def forward(

>>> url = "http://images.cocodataset.org/val2017/000000039769.jpg"
>>> image = Image.open(requests.get(url, stream=True).raw)
>>> text = "A picture of"

>>> inputs = processor(images=image, return_tensors="pt")
>>> inputs = processor(images=image, text=text, return_tensors="pt")
Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am curious about A picture of ...[what?] Is it my favorite 🐱 😹 ?

Copy link
Copy Markdown
Contributor Author

@younesbelkada younesbelkada Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahahah

Copy link
Copy Markdown
Contributor Author

@younesbelkada younesbelkada Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the model's responsibility to predict the correct word after "A picture of" :D

Copy link
Copy Markdown
Collaborator

@ydshieh ydshieh Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I put at the wrong line. But I also realized this doc example is forward not generate, so no prediction.
(it might be a good idea to add generate example too, but I am fine with the current example)


>>> outputs = model(**inputs)
```"""
Expand Down