Skip to content

[ProphetNet] Fix gradient checkpointing bug#21773

Closed
yhl48 wants to merge 5 commits into
huggingface:mainfrom
yhl48:fix-prophetnet
Closed

[ProphetNet] Fix gradient checkpointing bug#21773
yhl48 wants to merge 5 commits into
huggingface:mainfrom
yhl48:fix-prophetnet

Conversation

@yhl48
Copy link
Copy Markdown
Contributor

@yhl48 yhl48 commented Feb 24, 2023

What does this PR do?

Fixes #21737

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@yhl48
Copy link
Copy Markdown
Contributor Author

yhl48 commented Feb 24, 2023

the code quality seems to have failed due to some other files that were not changed, but could anyone please confirm if that is the case?

@HuggingFaceDocBuilderDev
Copy link
Copy Markdown

HuggingFaceDocBuilderDev commented Feb 24, 2023

The documentation is not available anymore as the PR was closed or merged.

@sgugger
Copy link
Copy Markdown
Collaborator

sgugger commented Feb 24, 2023

cc @gante

@gante
Copy link
Copy Markdown
Contributor

gante commented Feb 24, 2023

Hey @yhl48 -- same comment as in here (and the other PR has to be merged first) :)

@gante
Copy link
Copy Markdown
Contributor

gante commented Feb 24, 2023

(#21772 contains the changes here, closing this PR)

@gante gante closed this Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Generate] Fix gradient_checkpointing and use_cache bug for generate-compatible models

4 participants